Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug fix] Fixed/Refactored annotation layer code so that non-timeseries annotations are applied based on the updated chart object after adding all data #4630

Merged

Conversation

ghost
Copy link

@ghost ghost commented Mar 16, 2018

screen shot 2018-03-14 at 4 57 33 pm

screen shot 2018-03-14 at 4 54 20 pm

@codecov-io
Copy link

Codecov Report

Merging #4630 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4630      +/-   ##
==========================================
+ Coverage   71.22%   71.23%   +<.01%     
==========================================
  Files         190      190              
  Lines       14880    14884       +4     
  Branches     1098     1099       +1     
==========================================
+ Hits        10598    10602       +4     
  Misses       4279     4279              
  Partials        3        3
Impacted Files Coverage Δ
superset/assets/javascripts/chart/Chart.jsx 64.95% <0%> (-0.56%) ⬇️
superset/views/base.py 58.25% <0%> (+0.58%) ⬆️
superset/dataframe.py 98.75% <0%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97afcd5...f9134ec. Read the comment docs.

@ghost
Copy link
Author

ghost commented Mar 19, 2018

@jeffreythewang

Copy link
Contributor

@jeffreythewang jeffreythewang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@graceguo-supercat graceguo-supercat merged commit 73f7f81 into apache:master Mar 23, 2018
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
…es annotations are applied based on the updated chart object after adding all data (apache#4630)

* Fix how the annotation layer interpretes the timestamp string without timezone info; use it as UTC

* [Bug fix] Fixed/Refactored annotation layer code so that non-timeseries annotations are applied based on the updated chart object after adding all data

* [Bug fix] Fixed/Refactored annotation layer code so that non-timeseries annotations are applied based on the updated chart object after adding all data

* Fixed indentation
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Jun 12, 2018
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request Jun 14, 2018
timifasubaa pushed a commit to airbnb/superset-fork that referenced this pull request Jul 25, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
…es annotations are applied based on the updated chart object after adding all data (apache#4630)

* Fix how the annotation layer interpretes the timestamp string without timezone info; use it as UTC

* [Bug fix] Fixed/Refactored annotation layer code so that non-timeseries annotations are applied based on the updated chart object after adding all data

* [Bug fix] Fixed/Refactored annotation layer code so that non-timeseries annotations are applied based on the updated chart object after adding all data

* Fixed indentation
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.25.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants